You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Keep release-specific Bazel helpers out of the shared Rust crate definitions and colocate them with Bazel platform configuration.
Implementation
Moves multiplatform_binaries and its platform list from defs.bzl into bazel/platforms/release_binaries.bzl and updates the CLI load site. Behavior is unchanged.
Adding this tracked package under build/ by removing the broad ignore makes every other generated tree under /build visible to Git. In workflows that materialize paths the repo already references, such as build/linux/debian_bullseye_amd64-sysroot, git status will be flooded and those generated artifacts can be committed accidentally; keep /build/* ignored and add a narrow exception for /build/platforms/ instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep generated build outputs ignored
Intent
Keep release-specific Bazel helpers out of the shared Rust crate definitions and colocate them with Bazel platform configuration.
Implementation
Moves
multiplatform_binariesand its platform list fromdefs.bzlintobazel/platforms/release_binaries.bzland updates the CLI load site. Behavior is unchanged.Validation
bazel query //codex-rs/cli:release_binariesStack: 1 of 6.